From zbiggy at o2.pl  Sat Jan  3 23:18:11 2009
From: zbiggy at o2.pl (Zbigniew Luszpinski)
Date: Sat, 3 Jan 2009 22:18:11 +0000
Subject: [Lunar-commits] <moonbase> physfs: slight alteration to BUILD.
Message-ID: <200901032218.11909.zbiggy@o2.pl>

> commit 65f224c1d3b899b92e43f5066a1253f0f31cf351
> Author: Dennis 'stumbles' Veatch <stumbles at lunar-linux.org>
> Date:   Sat Jan 3 10:21:43 2009 -0500
>
>     physfs: slight alteration to BUILD.
> ---
>  devel/physfs/BUILD |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/devel/physfs/BUILD b/devel/physfs/BUILD
> index b8afad2..0dbeacb 100644
> --- a/devel/physfs/BUILD
> +++ b/devel/physfs/BUILD
> @@ -1,5 +1,9 @@
>  (
> -
> +
> +# Else the make fails on ccplus errors.
> +  unset CXXFLAGS &&
> +# end
> +
>    cmake -DCMAKE_INSTALL_PREFIX:=/usr &&
>    default_make

Ugly hack.
Dennis, it would be better if you just sed on fly breaking c++ flag from 
CXXFLAGS instead of dropping whole CXXFLAGS. Please post your CXXFLAGS (and 
error you get if you still have log).

have a nice day,
Zbigniew 'zbiggy' Luszpinski

From dennisveatch at bellsouth.net  Sun Jan  4 12:58:19 2009
From: dennisveatch at bellsouth.net (Dennis Veatch)
Date: Sun, 4 Jan 2009 06:58:19 -0500
Subject: [Lunar-commits] <moonbase> physfs: slight alteration to BUILD.
In-Reply-To: <200901032218.11909.zbiggy@o2.pl>
References: <200901032218.11909.zbiggy@o2.pl>
Message-ID: <200901040658.19811.dennisveatch@bellsouth.net>

On Saturday 03 January 2009 5:18:11 pm Zbigniew Luszpinski wrote:
> > commit 65f224c1d3b899b92e43f5066a1253f0f31cf351
snip
> > +
> > +# Else the make fails on ccplus errors.
> > +  unset CXXFLAGS &&
> > +# end
snip
>
> Ugly hack.
> Dennis, it would be better if you just sed on fly breaking c++ flag from
> CXXFLAGS instead of dropping whole CXXFLAGS. Please post your CXXFLAGS (and
> error you get if you still have log).
>
> have a nice day,
> Zbigniew 'zbiggy' Luszpinski
> _______________________________________________

I don't agree. But, if you think that is ugly, then take a gander at the 
audacity BUILD, and there are many others using unset.

The BUILD was failing on;

[100%] Building CXX object CMakeFiles/wxtest_physfs.dir/test/wxtest_physfs.o
cc1plus: warnings being treated as errors
In file included from /usr/include/wx-2.8/wx/wx.h:21,
...
...
...
make[2]: *** [CMakeFiles/wxtest_physfs.dir/test/wxtest_physfs.o] Error 1
make[1]: *** [CMakeFiles/wxtest_physfs.dir/all] Error 2
make: *** [all] Error 2

and using the default optimizations, with the exception of cpu=athlon64. 

If you know the method telling cmake NOT to treat warnings as errors, then 
feel free to alter the BUILD.

From me at v4hn.de  Sun Jan  4 15:32:35 2009
From: me at v4hn.de (v4hn)
Date: Sun, 4 Jan 2009 15:32:35 +0100
Subject: [Lunar-commits] <moonbase> physfs: slight alteration to BUILD.
In-Reply-To: <200901040658.19811.dennisveatch@bellsouth.net>
References: <200901032218.11909.zbiggy@o2.pl>
	<200901040658.19811.dennisveatch@bellsouth.net>
Message-ID: <20090104143235.GA2238@samsa>

On Sun, Jan 04, 2009 at 06:58:19AM -0500, Dennis Veatch wrote:
> The BUILD was failing on;
> 
> [100%] Building CXX object CMakeFiles/wxtest_physfs.dir/test/wxtest_physfs.o
> cc1plus: warnings being treated as errors
> In file included from /usr/include/wx-2.8/wx/wx.h:21,
> ...
> ...
> ...
> make[2]: *** [CMakeFiles/wxtest_physfs.dir/test/wxtest_physfs.o] Error 1
> make[1]: *** [CMakeFiles/wxtest_physfs.dir/all] Error 2
> make: *** [all] Error 2
> 
> and using the default optimizations, with the exception of cpu=athlon64. 
> 
> If you know the method telling cmake NOT to treat warnings as errors, then 
> feel free to alter the BUILD.

Why do you build this test at all?

> cmake -DCMAKE_INSTALL_PREFIX:=/usr -DPHYSFS_BUILD_WX_TEST:=FALSE &&

works quite well..


v4hn
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://foo-projects.org/pipermail/lunar-dev/attachments/20090104/5d9a7b7e/attachment.bin>

From dennisveatch at bellsouth.net  Sun Jan  4 16:31:58 2009
From: dennisveatch at bellsouth.net (Dennis Veatch)
Date: Sun, 4 Jan 2009 10:31:58 -0500
Subject: [Lunar-commits] <moonbase> physfs: slight alteration to BUILD.
In-Reply-To: <20090104143235.GA2238@samsa>
References: <200901032218.11909.zbiggy@o2.pl>
	<200901040658.19811.dennisveatch@bellsouth.net>
	<20090104143235.GA2238@samsa>
Message-ID: <200901041031.58954.dennisveatch@bellsouth.net>

On Sunday 04 January 2009 9:32:35 am v4hn wrote:
> On Sun, Jan 04, 2009 at 06:58:19AM -0500, Dennis Veatch wrote:
> > The BUILD was failing on;
> >
> > [100%] Building CXX object
> > CMakeFiles/wxtest_physfs.dir/test/wxtest_physfs.o cc1plus: warnings being
> > treated as errors
> > In file included from /usr/include/wx-2.8/wx/wx.h:21,
> > ...
> > ...
> > ...
> > make[2]: *** [CMakeFiles/wxtest_physfs.dir/test/wxtest_physfs.o] Error 1
> > make[1]: *** [CMakeFiles/wxtest_physfs.dir/all] Error 2
> > make: *** [all] Error 2
> >
> > and using the default optimizations, with the exception of cpu=athlon64.
> >
> > If you know the method telling cmake NOT to treat warnings as errors,
> > then feel free to alter the BUILD.
>
> Why do you build this test at all?

Ask whom ever redid the BUILD module when they switched to cmake. 

>
> > cmake -DCMAKE_INSTALL_PREFIX:=/usr -DPHYSFS_BUILD_WX_TEST:=FALSE &&
>
> works quite well..
>
>
> v4hn

That's exactly what I was looking for. Thanks.
-- 
You can tuna piano but you can't tune a fish.

http://www.lunar-linux.org/
It's worth the spin.

From zbiggy at o2.pl  Sun Jan  4 18:40:22 2009
From: zbiggy at o2.pl (Zbigniew Luszpinski)
Date: Sun, 4 Jan 2009 17:40:22 +0000
Subject: [Lunar-commits] <moonbase> physfs: slight alteration to BUILD.
In-Reply-To: <200901041031.58954.dennisveatch@bellsouth.net>
References: <200901032218.11909.zbiggy@o2.pl> <20090104143235.GA2238@samsa>
	<200901041031.58954.dennisveatch@bellsouth.net>
Message-ID: <200901041740.22435.zbiggy@o2.pl>

Sunday 04 January 2009 15:31:58 Dennis Veatch wrote:
> > Why do you build this test at all?
>
> Ask whom ever redid the BUILD module when they switched to cmake.

I did. This is the reason why CXXFLAGS did not fail on my machine:
bash-3.2$ lvu compile physfs | grep wx
-- Could NOT find wxWidgets  (missing:  wxWidgets_FOUND)
-- wxWidgets not found. Disabling wx test app.
--   Build wxWidgets test program: disabled

> > > cmake -DCMAKE_INSTALL_PREFIX:=/usr -DPHYSFS_BUILD_WX_TEST:=FALSE &&
> >
> > works quite well..
> >
> >
> > v4hn

Thank you v4hn for smart solution. Thanks to Dennis for commiting the 
solution. Now I'm happy :)

zbiggy

From duncan.gibson at xs4all.nl  Mon Jan  5 21:05:59 2009
From: duncan.gibson at xs4all.nl (Duncan Gibson)
Date: Mon, 5 Jan 2009 21:05:59 +0100 (CET)
Subject: Discuss module version management,
	how to handle multiple versions of a module?
Message-ID: <24673.82.93.24.95.1231185959.squirrel@webmail.xs4all.nl>

I was off-line and have no scrollback, so would someone be prepared to
summarize the discussion, either here or on a wiki page?

Cheers
Duncan / engelsman


From duncan.gibson at xs4all.nl  Sun Jan 11 21:39:57 2009
From: duncan.gibson at xs4all.nl (Duncan Gibson)
Date: Sun, 11 Jan 2009 21:39:57 +0100 (CET)
Subject: Module submission review script on doppio
Message-ID: <15533.82.93.24.95.1231706397.squirrel@webmail.xs4all.nl>

Sofar has a 'review' script for automating module submission handling
on doppie that you run in a test branch of your moonbase,git. It lets
you eyeball the patch in the editor, runs 'git am' to determine whether
the patch applies cleanly, and then lets you accept, reject or defer the
patch. The submitter receives an appropriate mail message.

In /home/engelsman/review.new on doppio I have an update to Sofar's
review script that provides an additional 'thank' option so that the
submitter gets a 'Thanks, but someone has updated it already' message,
and the queue is tidied.

Any ideas how it could be run in someone's local moonbase.git rather
than needing a session on doppio?

Cheers
Duncan / engelsman


From sofar at foo-projects.org  Mon Jan 12 19:37:56 2009
From: sofar at foo-projects.org (Kok, Auke)
Date: Mon, 12 Jan 2009 10:37:56 -0800
Subject: Module submission review script on doppio
In-Reply-To: <15533.82.93.24.95.1231706397.squirrel@webmail.xs4all.nl>
References: <15533.82.93.24.95.1231706397.squirrel@webmail.xs4all.nl>
Message-ID: <496B8E04.1050203@foo-projects.org>

Duncan Gibson wrote:
> Sofar has a 'review' script for automating module submission handling
> on doppie that you run in a test branch of your moonbase,git. It lets
> you eyeball the patch in the editor, runs 'git am' to determine whether
> the patch applies cleanly, and then lets you accept, reject or defer the
> patch. The submitter receives an appropriate mail message.
> 
> In /home/engelsman/review.new on doppio I have an update to Sofar's
> review script that provides an additional 'thank' option so that the
> submitter gets a 'Thanks, but someone has updated it already' message,
> and the queue is tidied.
> 
> Any ideas how it could be run in someone's local moonbase.git rather
> than needing a session on doppio?

that would totally be possible since the submissions are available on the
webserver. however, there is no way externally to purge entries from the queue.
You can send the "thank you" notes, but you can't remove the entry from the queue,
which makes it less useful.

Auke